Improved questions no_results_found message #9555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## main #9555 +/- ##
=======================================
Coverage ? 79.69%
=======================================
Files ? 98
Lines ? 5944
Branches ? 0
=======================================
Hits ? 4737
Misses ? 1207
Partials ? 0 |
TildaDares
force-pushed
the
questions-tab
branch
from
1b421cb
to
14b435a
Compare
TildaDares
force-pushed
the
questions-tab
branch
from
14b435a
to
5cddecb
Compare
|
Code Climate has analyzed commit 5cddecb and detected 0 issues on this pull request. View more on Code Climate. |
|
Hey @TildaDares I have created a break out issue for this here #9556 and I will link it to this...please do the same for any other subtasks you would like to work on so that we can keep the parent issue opened until all the issues are fixed. Thanks a lot for working on this |
cesswairimu
approved these changes
Apr 24, 2021
reginaalyssa
pushed a commit
to reginaalyssa/plots2
that referenced
this pull request
Oct 16, 2021
billymoroney1
pushed a commit
to billymoroney1/plots2
that referenced
this pull request
Dec 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9556
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
rake test@publiclab/reviewersfor help, in a comment belowIf tests do fail, click on the red
Xto learn why by reading the logs.Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!